Skip to content

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Oct 13, 2023

Fixes #3673 . This PR aims to standardize the method which determines whether an enumeration can be assigned to another type.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #4156 (24627a5) into master (6fa0a76) will decrease coverage by 0.019%.
Report is 2 commits behind head on master.
The diff coverage is 20.689%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #4156       +/-   ##
===============================================
- Coverage     57.986%   57.968%   -0.019%     
- Complexity      2329      2334        +5     
===============================================
  Files            645       645               
  Lines          34508     34531       +23     
  Branches        5971      5981       +10     
===============================================
+ Hits           20010     20017        +7     
- Misses         12351     12355        +4     
- Partials        2147      2159       +12     
Flag Coverage Δ
AlsoSlowTests 57.968% <20.689%> (-0.019%) ⬇️
javaparser-core 50.484% <0.000%> (-0.004%) ⬇️
javaparser-symbol-solver 37.128% <20.689%> (-0.005%) ⬇️
jdk-10 57.956% <20.689%> (-0.016%) ⬇️
jdk-11 57.956% <20.689%> (-0.019%) ⬇️
jdk-12 57.950% <20.689%> (-0.025%) ⬇️
jdk-13 57.956% <20.689%> (-0.019%) ⬇️
jdk-14 57.950% <20.689%> (-0.025%) ⬇️
jdk-15 57.956% <20.689%> (-0.016%) ⬇️
jdk-16 57.930% <20.689%> (-0.019%) ⬇️
jdk-8 57.952% <20.689%> (-0.019%) ⬇️
jdk-9 57.956% <20.689%> (-0.016%) ⬇️
macos-latest 57.962% <20.689%> (-0.019%) ⬇️
ubuntu-latest 57.947% <20.689%> (-0.019%) ⬇️
windows-latest 57.950% <20.689%> (-0.019%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...declarations/ResolvedReferenceTypeDeclaration.java 83.561% <100.000%> (+0.463%) ⬆️
...model/declarations/JavaParserClassDeclaration.java 80.272% <100.000%> (ø)
...rmodel/declarations/JavaParserEnumDeclaration.java 59.354% <ø> (-0.772%) ⬇️
...olver/javassistmodel/JavassistEnumDeclaration.java 50.000% <21.428%> (-5.173%) ⬇️
...ver/reflectionmodel/ReflectionEnumDeclaration.java 27.848% <0.000%> (-4.988%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d4319c...24627a5. Read the comment docs.

@jlerbsc jlerbsc merged commit 966e1f0 into javaparser:master Oct 13, 2023
@jlerbsc jlerbsc added this to the next release milestone Oct 13, 2023
@jlerbsc jlerbsc added the PR: Fixed A PR that offers a fix or correction label Oct 13, 2023
@jlerbsc
Copy link
Collaborator Author

jlerbsc commented Oct 13, 2023

I'm not sure this PR fixes all cases but it fixes your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Fixed A PR that offers a fix or correction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

isAssignableBy method StackOverflowError

1 participant