Fix for #3710 by cutting off resolution loops involving object creation steps. #4704
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4704 +/- ##
===============================================
- Coverage 58.198% 58.194% -0.005%
Complexity 2497 2497
===============================================
Files 670 670
Lines 38719 38720 +1
Branches 7022 7023 +1
===============================================
- Hits 22534 22533 -1
- Misses 13293 13295 +2
Partials 2892 2892
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
johanneskloos
force-pushed
the
johanneskloos/3710-infinite-recursion-involving-object-creation-scopes
branch
from
7bc20b7 to
dece4d5
Compare
| // is not the same as the current node. | ||
| while (notMethodNode instanceof MethodCallExpr | ||
| || notMethodNode instanceof FieldAccessExpr | ||
| || (notMethodNode instanceof ObjectCreationExpr && notMethodNode.hasScope()) |
There was a problem hiding this comment.
I'm not sure that the expression new A().new B() can be solved correctly.
There was a problem hiding this comment.
Please add a comment explaining simply and clearly why this has been added
There was a problem hiding this comment.
I have added a comment, and a unit test for the case you mentioned.
There was a problem hiding this comment.
In fact, I added two unit tests :)
| "com.github.javaparser.symbolsolver.Outer.make()", resolvedMethod.getQualifiedSignature()); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Please include these classes in the source code to be parsed.
This is adapted from my own example and the example in 3710, to make up a more-or-less minimal reproduction case.
Without this check, the symbol resolver would loop between resolving a method call (used as scope argument for a new object creation) and resolving the method call's scope.
johanneskloos
force-pushed
the
johanneskloos/3710-infinite-recursion-involving-object-creation-scopes
branch
from
353f1ad to
c189a15
Compare
…ner class creation resolution with a constructor base work as expected.
johanneskloos
force-pushed
the
johanneskloos/3710-infinite-recursion-involving-object-creation-scopes
branch
from
c189a15 to
84441d0
Compare
|
Thank you for your contribution |
2 participants
Fixes #3710.
The idea of the fix is that the scope in inner class object creation expressions, e.g.,
makeOuter().new Inner(), can cause resolution loops in just the same way that the scope of a field access or method call can, and should be handled in the same way.