Skip to content

Conversation

@christianhegedues
Copy link
Member

No description provided.

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Jan 18, 2020
@javascript-translate-bot javascript-translate-bot requested a review from a team January 18, 2020 16:57
@javascript-translate-bot javascript-translate-bot added needs +1 One more review needed and removed review needed Review needed, please approve or request changes labels Jan 20, 2020
Copy link
Contributor

@1H0 1H0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the du-form instead of Sie... It's more personal and it's done like that in the other articles. It would be great if we could be conistent with that...

But beside that: Great translation, thank you! 👍

@javascript-translate-bot javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label Jan 20, 2020
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@christianhegedues
Copy link
Member Author

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jan 20, 2020
@javascript-translate-bot javascript-translate-bot requested a review from a team January 20, 2020 16:46
@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Jan 21, 2020
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

christianhegedues and others added 3 commits January 21, 2020 20:23
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
Co-Authored-By: Gabriel Jörg <jergo3020@gmail.com>
Co-Authored-By: Gabriel Jörg <jergo3020@gmail.com>
@christianhegedues christianhegedues force-pushed the de/03-strict-mode branch 2 times, most recently from 4732c43 to 2ec376b Compare January 21, 2020 19:40
Co-Authored-By: Gabriel Jörg <jergo3020@gmail.com>
@christianhegedues
Copy link
Member Author

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jan 21, 2020
@javascript-translate-bot javascript-translate-bot requested a review from a team January 21, 2020 19:48
@1H0 1H0 removed the review needed Review needed, please approve or request changes label Jan 24, 2020
@NamikoYa NamikoYa added ready to merge and removed needs +1 One more review needed labels Feb 3, 2020
@NamikoYa NamikoYa merged commit 2d05c0e into javascript-tutorial:master Feb 3, 2020
@christianhegedues christianhegedues deleted the de/03-strict-mode branch February 10, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants