Sync with upstream @ 5cb9760a #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\n in strings
[strings] 2 code units are 4 bytes
[strings] special characters
[strings] localeCompare
Not sure if it's what you wanted to say but the original sentence is not accurate I think.
typo in "by no means"
change parameter name to the set one
Update article.md
Fixed typo
Update article.md
I fixed some of the awkward phrasing: • `concrete` is more common in the literary style of writing and is used to denote something opposite of abstract, so placing it here when describing a relation between html elements seems unnecessarily cumbersome. Plus there's some tautology in using `concrete` together with `actually`. I propose something simpler. • `It’s possible that event.target equals this` -- the present indefinite tense is not quite correctly used here, because this sentence describes something that only happens conditionally and is not always true. There are many ways to rewrite this sentence, and I propose one that aims to keep the original structure of the idea.
Add stylistic and grammar fixes
Corrected no-declaration object destructuring
[strings] Surrogate pairs S example
Modify terms based on the official document. - https://developers.google.com/web/tools/chrome-devtools/
Update article.md
|
|
|
@alexgarbarev @jinpae please check for Contributor License Agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated to merge changes from en.javascript.info at 5cb9760
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
Click to open a list of 223 files
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.infogit checkout mastergit pull upstream mastergit checkout --ours <path>git diff --word-diff master...upstream/master <path>(please note: three dots in the command)git push origin masterPlease ignore changes in README.md (git checkout --ours README.md && git commit -m ignore README.md).
This PR will be closed and replaced with a new one in a few days.