Fix closeness tests in testOnComplexPlane for small inputs. Update expm1 inaccuracy regions. #20144

pearu · 2024-03-08T18:29:16Z

As in the title.

openxla/xla#10376 fixes all inaccuracy issues in jax.numpy.expm1:

before this PR the inaccuracies and mismatch rate was 17.7%
after this PR the inaccuracies rate is 0.1%

openxla/xla#10503 fixes all inaccuracy issues in jax.numpy.log1p:

before this PR the mismatch rate was 42.5%
after this PR the inaccuracies rate is 0%
In addition to log1p, there exists accuracy improvements for arctanh:
- jax.numpy.arctanh mistmatch before is 55.5% and after 11.3 %

openxla/xla#10525 fixes all inaccuracy issues in jax.numpy.tan:

TBD

jakevdp · 2024-03-08T18:54:55Z

There are some failures in one of the CI jobs – looks like inf/nan mismatches.

pearu · 2024-03-08T19:16:44Z

There are some failures in one of the CI jobs – looks like inf/nan mismatches.

Yes, I am in a process of fixing these. These emerged because the closeness checking is changed in this PR and the mapping of inaccuracy lists requires updates re the tests that passed false-positively before.

jakevdp · 2024-03-13T17:16:13Z

Tests are failing on internal CPU.

Overall, I think the issue here is that these tests are too brittle: they make detailed assertions about the dark corners of hardware-dependent implementation details. Rather than add more exceptions for particular backends / package versions / devices / etc. I think it would be better to make the tests simpler and less brittle. What do you think?

pearu · 2024-03-13T17:16:22Z

xla_extension_version >= 244 needs to be updated as the current xla_extension_version value conflicts with the one in the main branch, hence the test failures.

pearu · 2024-03-13T17:52:29Z

... I think it would be better to make the tests simpler and less brittle.

I agree. I suggest replacing numpy with mpmath as a reference library.

tests/lax_test.py

pearu · 2024-03-22T17:07:33Z

Closing as #20373 has landed.

The items in the description will be addressed in follow-up PRs.

reedwm · 2024-03-26T02:16:44Z

@pearu, are the XLA PRs that address the inaccuracies ready for review? That is, are the following PRs ready for review?

Improve the accuracy of asin(x) and asinh(x) for complex x using modified Hull et al algorithm. openxla/xla#8589
Fix expm1 inaccuracies on complex inputs with small absolute values. Add Cosm1. openxla/xla#10376
Fix log1p inaccuracies on complex inputs with large absolute values. openxla/xla#10503
Fix tan inaccuracies on complex inputs with large and small absolute values openxla/xla#10525

…te values. Add Cosm1. Imported from GitHub PR openxla/xla#10376 As in the title. Tests and improvement reports are in jax-ml/jax#20144. Accuracy tests are enabled in jax-ml/jax#20436 Copybara import of the project: -- 42e222a436787c52adf453c8c0c39125b010e2b2 by Pearu Peterson <pearu.peterson@gmail.com>: Fix expm1 inaccuracies on complex inputs with small absolute values. Add Cosm1. Fix expm1(x+yi) when x is large and y is zero. Merging this change closes #10376 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10376 from pearu:pearu/expm1 42e222a436787c52adf453c8c0c39125b010e2b2 PiperOrigin-RevId: 619208374

…te values. Add Cosm1. Imported from GitHub PR #10376 As in the title. Tests and improvement reports are in jax-ml/jax#20144. Accuracy tests are enabled in jax-ml/jax#20436 Copybara import of the project: -- 42e222a by Pearu Peterson <pearu.peterson@gmail.com>: Fix expm1 inaccuracies on complex inputs with small absolute values. Add Cosm1. Fix expm1(x+yi) when x is large and y is zero. Merging this change closes #10376 COPYBARA_INTEGRATE_REVIEW=#10376 from pearu:pearu/expm1 42e222a PiperOrigin-RevId: 619324160

…te values. Add Cosm1. Imported from GitHub PR openxla/xla#10376 As in the title. Tests and improvement reports are in jax-ml/jax#20144. Accuracy tests are enabled in jax-ml/jax#20436 Copybara import of the project: -- 42e222a436787c52adf453c8c0c39125b010e2b2 by Pearu Peterson <pearu.peterson@gmail.com>: Fix expm1 inaccuracies on complex inputs with small absolute values. Add Cosm1. Fix expm1(x+yi) when x is large and y is zero. Merging this change closes #10376 PiperOrigin-RevId: 619324160

…te values. Imported from GitHub PR #10503 As in the title. Tests and improvement reports are in jax-ml/jax#20144. Accuracy tests are enabled in jax-ml/jax#20436 Copybara import of the project: -- 2b8f253 by Pearu Peterson <pearu.peterson@gmail.com>: Fix log1p inaccuracies on complex inputs with large absolute values. -- d35cef4 by Pearu Peterson <pearu.peterson@gmail.com>: Add tests to complex Log1p Merging this change closes #10503 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10503 from pearu:pearu/log1p d35cef4 PiperOrigin-RevId: 620293408

…te values. Imported from GitHub PR openxla/xla#10503 As in the title. Tests and improvement reports are in jax-ml/jax#20144. Accuracy tests are enabled in jax-ml/jax#20436 Copybara import of the project: -- 2b8f2539d6bf364c0a97f65e186430c5eb3ed07b by Pearu Peterson <pearu.peterson@gmail.com>: Fix log1p inaccuracies on complex inputs with large absolute values. -- d35cef4f5fa09482c49edfee709e86c5ca29adde by Pearu Peterson <pearu.peterson@gmail.com>: Add tests to complex Log1p Merging this change closes #10503 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10503 from pearu:pearu/log1p d35cef4f5fa09482c49edfee709e86c5ca29adde PiperOrigin-RevId: 620293408

…te values. Imported from GitHub PR #10503 As in the title. Tests and improvement reports are in jax-ml/jax#20144. Accuracy tests are enabled in jax-ml/jax#20436 Copybara import of the project: -- 2b8f253 by Pearu Peterson <pearu.peterson@gmail.com>: Fix log1p inaccuracies on complex inputs with large absolute values. -- d35cef4 by Pearu Peterson <pearu.peterson@gmail.com>: Add tests to complex Log1p Merging this change closes #10503 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10503 from pearu:pearu/log1p d35cef4 PiperOrigin-RevId: 620293408

…te values. Imported from GitHub PR openxla/xla#10503 As in the title. Tests and improvement reports are in jax-ml/jax#20144. Accuracy tests are enabled in jax-ml/jax#20436 Copybara import of the project: -- 2b8f2539d6bf364c0a97f65e186430c5eb3ed07b by Pearu Peterson <pearu.peterson@gmail.com>: Fix log1p inaccuracies on complex inputs with large absolute values. -- d35cef4f5fa09482c49edfee709e86c5ca29adde by Pearu Peterson <pearu.peterson@gmail.com>: Add tests to complex Log1p Merging this change closes #10503 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10503 from pearu:pearu/log1p d35cef4f5fa09482c49edfee709e86c5ca29adde PiperOrigin-RevId: 620293408

…te values. Imported from GitHub PR #10503 As in the title. Tests and improvement reports are in jax-ml/jax#20144. Accuracy tests are enabled in jax-ml/jax#20436 Copybara import of the project: -- 2b8f253 by Pearu Peterson <pearu.peterson@gmail.com>: Fix log1p inaccuracies on complex inputs with large absolute values. -- d35cef4 by Pearu Peterson <pearu.peterson@gmail.com>: Add tests to complex Log1p Merging this change closes #10503 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10503 from pearu:pearu/log1p d35cef4 PiperOrigin-RevId: 620293408

…te values. Imported from GitHub PR openxla/xla#10503 As in the title. Tests and improvement reports are in jax-ml/jax#20144. Accuracy tests are enabled in jax-ml/jax#20436 Copybara import of the project: -- 2b8f2539d6bf364c0a97f65e186430c5eb3ed07b by Pearu Peterson <pearu.peterson@gmail.com>: Fix log1p inaccuracies on complex inputs with large absolute values. -- d35cef4f5fa09482c49edfee709e86c5ca29adde by Pearu Peterson <pearu.peterson@gmail.com>: Add tests to complex Log1p Merging this change closes #10503 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10503 from pearu:pearu/log1p d35cef4f5fa09482c49edfee709e86c5ca29adde PiperOrigin-RevId: 620293408

…te values. Imported from GitHub PR #10503 As in the title. Tests and improvement reports are in jax-ml/jax#20144. Accuracy tests are enabled in jax-ml/jax#20436 Copybara import of the project: -- 2b8f253 by Pearu Peterson <pearu.peterson@gmail.com>: Fix log1p inaccuracies on complex inputs with large absolute values. -- d35cef4 by Pearu Peterson <pearu.peterson@gmail.com>: Add tests to complex Log1p Merging this change closes #10503 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10503 from pearu:pearu/log1p d35cef4 PiperOrigin-RevId: 621891416

…te values. Imported from GitHub PR openxla/xla#10503 As in the title. Tests and improvement reports are in jax-ml/jax#20144. Accuracy tests are enabled in jax-ml/jax#20436 Copybara import of the project: -- 2b8f2539d6bf364c0a97f65e186430c5eb3ed07b by Pearu Peterson <pearu.peterson@gmail.com>: Fix log1p inaccuracies on complex inputs with large absolute values. -- d35cef4f5fa09482c49edfee709e86c5ca29adde by Pearu Peterson <pearu.peterson@gmail.com>: Add tests to complex Log1p Merging this change closes #10503 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10503 from pearu:pearu/log1p d35cef4f5fa09482c49edfee709e86c5ca29adde PiperOrigin-RevId: 621891416

…te values. Imported from GitHub PR #10503 As in the title. Tests and improvement reports are in jax-ml/jax#20144. Accuracy tests are enabled in jax-ml/jax#20436 Copybara import of the project: -- 2b8f253 by Pearu Peterson <pearu.peterson@gmail.com>: Fix log1p inaccuracies on complex inputs with large absolute values. -- d35cef4 by Pearu Peterson <pearu.peterson@gmail.com>: Add tests to complex Log1p Merging this change closes #10503 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10503 from pearu:pearu/log1p d35cef4 PiperOrigin-RevId: 620293408

…te values. Imported from GitHub PR openxla/xla#10503 As in the title. Tests and improvement reports are in jax-ml/jax#20144. Accuracy tests are enabled in jax-ml/jax#20436 Copybara import of the project: -- 2b8f2539d6bf364c0a97f65e186430c5eb3ed07b by Pearu Peterson <pearu.peterson@gmail.com>: Fix log1p inaccuracies on complex inputs with large absolute values. -- d35cef4f5fa09482c49edfee709e86c5ca29adde by Pearu Peterson <pearu.peterson@gmail.com>: Add tests to complex Log1p Merging this change closes #10503 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10503 from pearu:pearu/log1p d35cef4f5fa09482c49edfee709e86c5ca29adde PiperOrigin-RevId: 620293408

…te values. Imported from GitHub PR #10503 As in the title. Tests and improvement reports are in jax-ml/jax#20144. Accuracy tests are enabled in jax-ml/jax#20436 Copybara import of the project: -- 2b8f253 by Pearu Peterson <pearu.peterson@gmail.com>: Fix log1p inaccuracies on complex inputs with large absolute values. -- d35cef4 by Pearu Peterson <pearu.peterson@gmail.com>: Add tests to complex Log1p Merging this change closes #10503 COPYBARA_INTEGRATE_REVIEW=#10503 from pearu:pearu/log1p d35cef4 PiperOrigin-RevId: 621917683

…te values. Imported from GitHub PR openxla/xla#10503 As in the title. Tests and improvement reports are in jax-ml/jax#20144. Accuracy tests are enabled in jax-ml/jax#20436 Copybara import of the project: -- 2b8f2539d6bf364c0a97f65e186430c5eb3ed07b by Pearu Peterson <pearu.peterson@gmail.com>: Fix log1p inaccuracies on complex inputs with large absolute values. -- d35cef4f5fa09482c49edfee709e86c5ca29adde by Pearu Peterson <pearu.peterson@gmail.com>: Add tests to complex Log1p Merging this change closes #10503 PiperOrigin-RevId: 621917683

… absolute values. Add Cosm1. Imported from GitHub PR openxla#10376 As in the title. Tests and improvement reports are in jax-ml/jax#20144. Accuracy tests are enabled in jax-ml/jax#20436 Copybara import of the project: -- 42e222a by Pearu Peterson <pearu.peterson@gmail.com>: Fix expm1 inaccuracies on complex inputs with small absolute values. Add Cosm1. Fix expm1(x+yi) when x is large and y is zero. Merging this change closes openxla#10376 COPYBARA_INTEGRATE_REVIEW=openxla#10376 from pearu:pearu/expm1 42e222a PiperOrigin-RevId: 619324160

pearu mentioned this pull request Mar 8, 2024

Fix expm1 inaccuracies on complex inputs with small absolute values. Add Cosm1. openxla/xla#10376

Closed

pearu requested review from hawkinsp and jakevdp March 8, 2024 18:31

pearu force-pushed the pearu/expm1 branch from 435ba8c to ba8a879 Compare March 8, 2024 18:40

jakevdp approved these changes Mar 8, 2024

View reviewed changes

google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Mar 8, 2024

jakevdp self-assigned this Mar 8, 2024

kokoro-team removed the kokoro:force-run label Mar 8, 2024

pearu force-pushed the pearu/expm1 branch from ba8a879 to c4fdd4a Compare March 8, 2024 18:53

pearu force-pushed the pearu/expm1 branch from c4fdd4a to 0532131 Compare March 8, 2024 19:13

pearu mentioned this pull request Mar 11, 2024

Improve the accuracy of asin(x) and asinh(x) for complex x using modified Hull et al algorithm. openxla/xla#8589

Closed

pearu requested a review from jakevdp March 12, 2024 08:37

pearu force-pushed the pearu/expm1 branch from 0532131 to 2b9a713 Compare March 12, 2024 09:07

pearu mentioned this pull request Mar 13, 2024

Fix log1p inaccuracies on complex inputs with large absolute values. openxla/xla#10503

Closed

pearu force-pushed the pearu/expm1 branch from 2b9a713 to dcab6d0 Compare March 13, 2024 11:58

jakevdp approved these changes Mar 13, 2024

View reviewed changes

google-ml-butler bot added the kokoro:force-run label Mar 13, 2024

kokoro-team removed the kokoro:force-run label Mar 13, 2024

jakevdp added pull ready Ready for copybara import and testing and removed pull ready Ready for copybara import and testing labels Mar 13, 2024

pearu mentioned this pull request Mar 13, 2024

Fix tan inaccuracies on complex inputs with large and small absolute values openxla/xla#10525

Closed

pearu force-pushed the pearu/expm1 branch 2 times, most recently from bb60eca to 67a8a9b Compare March 21, 2024 16:41

jakevdp reviewed Mar 21, 2024

View reviewed changes

tests/lax_test.py Outdated Show resolved Hide resolved

jakevdp added the pull ready Ready for copybara import and testing label Mar 21, 2024

kokoro-team removed the kokoro:force-run label Mar 21, 2024

jakevdp assigned hawkinsp and unassigned jakevdp Mar 22, 2024

pearu closed this Mar 22, 2024

copybara-service bot mentioned this pull request Mar 26, 2024

PR #10376: Fix expm1 inaccuracies on complex inputs with small absolute values. Add Cosm1. tensorflow/tensorflow#64523

Merged

copybara-service bot mentioned this pull request Apr 4, 2024

PR #10503: Fix log1p inaccuracies on complex inputs with large absolute values. openxla/xla#11196

Merged

copybara-service bot mentioned this pull request Apr 4, 2024

PR #10503: Fix log1p inaccuracies on complex inputs with large absolute values. tensorflow/tensorflow#65032

Merged

copybara-service bot mentioned this pull request Apr 4, 2024

PR #10503: Fix log1p inaccuracies on complex inputs with large absolute values. openxla/xla#11218

Closed

copybara-service bot mentioned this pull request Apr 4, 2024

PR #10503: Fix log1p inaccuracies on complex inputs with large absolute values. tensorflow/tensorflow#65068

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix closeness tests in testOnComplexPlane for small inputs. Update expm1 inaccuracy regions. #20144

Fix closeness tests in testOnComplexPlane for small inputs. Update expm1 inaccuracy regions. #20144

Uh oh!

pearu commented Mar 8, 2024 •

edited

Loading

Uh oh!

jakevdp commented Mar 8, 2024

Uh oh!

pearu commented Mar 8, 2024

Uh oh!

jakevdp commented Mar 13, 2024

Uh oh!

pearu commented Mar 13, 2024

Uh oh!

pearu commented Mar 13, 2024

Uh oh!

Uh oh!

pearu commented Mar 22, 2024

Uh oh!

reedwm commented Mar 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Fix closeness tests in testOnComplexPlane for small inputs. Update expm1 inaccuracy regions. #20144

Fix closeness tests in testOnComplexPlane for small inputs. Update expm1 inaccuracy regions. #20144

Uh oh!

Conversation

pearu commented Mar 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakevdp commented Mar 8, 2024

Uh oh!

pearu commented Mar 8, 2024

Uh oh!

jakevdp commented Mar 13, 2024

Uh oh!

pearu commented Mar 13, 2024

Uh oh!

pearu commented Mar 13, 2024

Uh oh!

Uh oh!

pearu commented Mar 22, 2024

Uh oh!

reedwm commented Mar 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pearu commented Mar 8, 2024 •

edited

Loading