Skip to content

Conversation

@jaxxstorm
Copy link
Owner

@jaxxstorm jaxxstorm commented Jun 21, 2025

Signed-off-by: Lee Briggs lee@leebriggs.co.uk


Important

Rename configuration key format to output across multiple command files for consistent output configuration.

  • Configuration Key Rename:
    • Rename configuration key format to output in cmd/tscli/config/show/cli.go, cmd/tscli/create/integration/cli.go, and cmd/tscli/create/invite/device/cli.go.
    • Update output.Print calls to use viper.GetString("output") instead of viper.GetString("format") in 30+ files.
  • Miscellaneous:
    • Change import order in cmd/tscli/list/cli.go to maintain consistency.

This description was created by Ellipsis for e5f8c8c. You can customize this summary. It will automatically update as commits are pushed.

Signed-off-by: Lee Briggs <lee@leebriggs.co.uk>
@ellipsis-dev ellipsis-dev bot changed the title ... refactor: rename format to output for output configuration Jun 21, 2025
@jaxxstorm jaxxstorm merged commit 7fa3f7e into main Jun 21, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to e5f8c8c in 57 seconds. Click for details.
  • Reviewed 842 lines of code in 54 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. cmd/tscli/list/logs/network/cli.go:71
  • Draft comment:
    The code still uses viper.GetString("format") instead of viper.GetString("output"). Update it to use "output" for consistency.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. cmd/tscli/delete/webhook/cli.go:21
  • Draft comment:
    Typo in the short description: "Deletea webhook" should be "Delete a webhook".
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_PYadHsl3QHpamt9X

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@jaxxstorm jaxxstorm deleted the output_format branch June 23, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants