[WIP] added experimental multidb support#256
[WIP] added experimental multidb support#256tg44 wants to merge 1 commit intoNginxProxyManager:masterfrom
Conversation
|
If you're still considering doing this PR, please open again against the |
|
Maybe I'm the sensitive, but this is kinda rude. I made this PR ~3 month ago. You don't even comment it, and now I should reopen it? Ofc I will do it bcs I want to work with sqlite instead of mysql, but still, at least you could mention if its a good or a bad set of modifications... |
|
Honestly, I haven't had time to invest in this project over the last 6 months. I'm happy for this change to go in once it's fully tested, but since the CI was down at the time you submitted the PR, there hasn't been a docker image for anyone to test with. |
|
CI is back though, your next pr will be built for you and others to test. |
|
Hi, @jc21 and @tg44 Thank you~ |
|
I think it can be recreated based on this PR. I run a mysql server right now (for basically no reason :( ). If you need further help, I try to help, just summon me to some comment section. |
It's probably not a single-commit change, but I will summarize what I done;
knex-nativeengine (db.jsandinstall.md)20190227065017_settings.js)setup.js)now_helpernow_helperinstead of theModel.rawIf you want atomic commits I think the correct steps would be:
It is working with sqlite3 right now. I didn't test mysql, and pg. (Also probably would be nice to make the compose stack to support examples to all three and add default configs to all three.)
(I love the idea and the functionality BTW, really nice app!)
Probably fixes #185 and fixes #200