Skip to content

Conversation

@SeiyaKobayashi
Copy link
Collaborator

@SeiyaKobayashi SeiyaKobayashi commented May 22, 2025

🌈 Overview

Complete implementation of JPYC Python SDK v1.

🎯 Issues

🎨 Details

  • Supports 17 critical methods of JPYCv2 contracts
  • Easily-configurable SDK clients
  • Code examples for all the JPYC methods
  • Over 100 unit tests with over 90% coverage

📚 References

@SeiyaKobayashi SeiyaKobayashi self-assigned this May 22, 2025
@SeiyaKobayashi SeiyaKobayashi requested a review from Mameta29 as a code owner May 22, 2025 05:03
@SeiyaKobayashi SeiyaKobayashi linked an issue May 22, 2025 that may be closed by this pull request
@SeiyaKobayashi
Copy link
Collaborator Author

SeiyaKobayashi commented May 22, 2025

@Mameta29

create-release-pr のワークフローが落ちていますが無視して ok です
こちらは初めはリリースする PR がないため、挙動としては正しい認識です

Mameta29
Mameta29 previously approved these changes May 24, 2025
Copy link
Collaborator

@Mameta29 Mameta29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests, exampleともに挙動確認できました。

@SeiyaKobayashi SeiyaKobayashi merged commit 2c6e2c8 into develop May 24, 2025
2 checks passed
@SeiyaKobayashi SeiyaKobayashi deleted the fix/develop branch May 24, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Interfaces of JPYCv2 Contracts

3 participants