-
Notifications
You must be signed in to change notification settings - Fork 5
Feature/support json patch #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0e2d89a
Fix karma config
86d0642
Implements patch
f6ce045
Make syntax more dens
01cc8fa
Make syntax more dense
1fff211
Merge branch 'feature/support-json-patch' of https://github.com/jcass…
e919a49
Fix jshint
bec1c5b
Run jshint from gulp
05355d7
Adds unit test for context.httpPatch method
d1d1189
Add jshint to default task
acdc4cb
Fix content type for patch request
61fab8e
Merge patch recursively
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,12 +10,16 @@ | |
| "gulp": "^3.9", | ||
| "gulp-batch": "^1.0", | ||
| "gulp-concat": "^2.6", | ||
| "gulp-if": "^2.0.0", | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This can go too, now. I'll remove it. |
||
| "gulp-ignore": "^1.2", | ||
| "gulp-jshint": "^1.11.2", | ||
| "gulp-watch": "^4.3", | ||
| "jasmine-core": "^2.3.4", | ||
| "jshint": "^2.8", | ||
| "jshint-stylish": "^2.0.1", | ||
| "karma": "^0.13", | ||
| "karma-coverage": "^0.4", | ||
| "karma-jasmine": "^0.3", | ||
| "karma-jasmine": "^0.3.6", | ||
| "karma-phantomjs-launcher": "^0.2" | ||
| }, | ||
| "scripts": { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -110,6 +110,28 @@ angular.module('hypermedia') | |
| }); | ||
| }}, | ||
|
|
||
| /** | ||
| * Perform a HTTP PATCH request. | ||
| * | ||
| * @function | ||
| * @param {Resource} resource | ||
| * @returns a promise that is resolved to the resource | ||
| * @see Resource#$patchRequest | ||
| */ | ||
| httpPatch: {value: function (resource, data) { | ||
| var self = this; | ||
| busyRequests += 1; | ||
| var request = updateHttp(resource.$patchRequest(data)); | ||
| return $http(request).then(function () { | ||
| Resource.prototype.$merge.call(resource, request.data); | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point using |
||
| return self.markSynced(resource, Date.now()); | ||
| }).then(function () { | ||
| return resource; | ||
| }).finally(function () { | ||
| busyRequests -= 1; | ||
| }); | ||
| }}, | ||
|
|
||
| /** | ||
| * Perform a HTTP DELETE request and unmark the resource as synchronized. | ||
| * | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
jshintis quick we could add this to the default task.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.