Cyclic graphs and self-connected nodes?

[SunakazeKun]

Hello, I'm currently seeking help with a project which utilizes NodeGraphQt for flowchart editing. I thought this might be the right place to ask as one of the labels says "help wanted". In my case, I have graphs that can be cyclic. Furthermore, it's also possible that a node's output is directly connected to its input again. Now, I've noticed that NodeGraph::auto_layout_nodes causes a stack overflow in this case due to recursion. Is there maybe another way to accomplish automatically generated layouts in those cases?
Also, I've noticed that the pipe goes through the node when its output is connected with the input of the same node. Is there a way to make it go around the node?

Below is a simple example of a graph which causes the problems described above. In this case, I wasn't able to use auto_layout_nodes so I moved the nodes around manually. You can also see that the last node connects to itself again. This is a desired behavior that I need in my case:

[jchanvfx]

Hi @SunakazeKun,

Thanks for the example 😺 , for the auto_layout_nodes func will probably have to revisit the code at some stage as for the pipes to be drawn around a node you'll have to add some additional logic to the pipe drawing functions.

I probably won't be getting to that anytime soon but if you want to have a go yourself here's the two function that'll need to be tweaked.
https://github.com/jchanvfx/NodeGraphQt/blob/main/NodeGraphQt/qgraphics/pipe.py#L161
https://github.com/jchanvfx/NodeGraphQt/blob/main/NodeGraphQt/qgraphics/pipe.py#L205

Cheers,
Johnny

[jchanvfx]

I've just implemented some updates to the pipe drawing logic here #336

[SunakazeKun]

Nice, very cool stuff :>

[jchanvfx]

Addressed in version v0.5.10

https://github.com/jchanvfx/NodeGraphQt/releases/tag/v0.5.10