Some fix I made while implementing a basic evaluation system #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 15, 2020 16:02
Owner
|
This is awesome thanks for contributing 😺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi jchanvfx,
When i query the properties of a node with the has_property() method, i could not see the custom properties that i had previously created.
I replaced self.model.properties.keys() for self.model.custom_properties.keys().
The callbacks on_input connected() and on_input_disconnected() are executed before the ports connect. I don't know if that's a bug, or it's done on purpose. In any case, it may be necessary to have a callback that runs before connecting and another that runs after connecting.
I added also a example of a node wrapper for math functions