Remove circular reference #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`line_edit` was both the parent and the central widget of `searchWidget`, causing a circular reference in the objects parenting (resulting in a segfault).
piiq
approved these changes
Nov 17, 2020
piiq
left a comment
piiq
left a comment
There was a problem hiding this comment.
Hi, I've tested this on the master branch and it worked out great. The nodes have loaded, the segfault is gone.
Owner
|
Awesome thanks guys 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Every time NodeGraph is instanced, the QApplication would exit with a segfault
(causing a non zero return code, that it turns breaks my CI, which makes me sad 😿)
Solution
In
NodeGraphQt/widgets/tab_search.py,line_editwas both the parent and the central widget ofsearchWidget,causing a circular reference in the objects parenting (resulting in a segfault).
Reparenting
searchWidgetunderselffixes the issue.