Skip to content

Conversation

@samyhocine
Copy link
Contributor

Hi,

First of all, thanks for the work, NodeGraphQt is very plug & play and easy to customize.

From version 0.1.8 to 0.2.0 we lost the ability to install NodeGraphQt using pip because "setup.py" is missing.

Even tough there is a "setup.cfg" file, pip still needs a dummy "setup.py" file.

In this pull request, I've added the setup.py file and added two fields in the setup.cfg file :

  • name
  • version

Best regards,

Samy

@jchanvfx jchanvfx merged commit 55debf9 into jchanvfx:master May 18, 2022
@jchanvfx
Copy link
Owner

jchanvfx commented May 18, 2022

Awesome thanks @samyhocine 😃

@mara004
Copy link
Contributor

mara004 commented May 18, 2022

#250 seems to have gone a bit wrong. In #222, setup.py was never supposed to be removed (see the diff). Moreover, I think at least version should be read dynamically from NodeGraphQt.pkg_info to avoid possible inconsistency.

jchanvfx added a commit that referenced this pull request May 18, 2022
@jchanvfx
Copy link
Owner

Ah yup cool thanks @mara004 I've just made another push 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants