Fixed another quick API change of Qt6 on mouse selection rectangle #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt6 no longer accepts the same type of argument for the scene setSelectionArea. This commit fixes the issue by just falling back to the default selection rectangle behaviour which is the same as the intended behaviour on previous implementation.
Merge latest changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge contains your latest changes and fixes another tiny API change on Qt6 on mouse selection rectangle.
I've just removed the faulty argument type that changed on Qt6 and delegated to default behaviour on selection rectangle which I think it was your intented one so nothing changes normally.