Implement #93: Vendoring Qt.py #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `QtWidgets.QGraphicsSceneMouseEvent` class doesn't have `setModifiers()` method in PyQt5, and cannot find a workaround for it. So the only option to stick with PyQt5 for now was to drop the modifier remapping, but judging from the event passing flow and running a few tests, it looks like those remapping code didn't have any effect to the UI function. Should be safe to remove them.
While using PyQt5 binding, the node attribute `type` caused "TypeError: 'str' object is not callable" in `QGraphicsScene.createItemGroup`, rename to `type_` solved this.
Contributor
Author
|
Contributor
Author
|
BTW, this also solved #92. |
Owner
|
great work thanks for contributing @davidlatwe 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @jchanvfx
This PR implemented the vendoring of Qt.py (#93), since my environment was using PyQt5, so I made this attempt.
I tested with the
example.pyin both PyQt5 and PySide2 environment and all functions work. Should be also support PySide and PyQt4 as well, and won't affect the development.