Skip to content

Adds silver background colour to inputs disabled type email, password, text#110

Merged
jdan merged 5 commits intojdan:mainfrom
lwkchan:patch-1
Mar 16, 2021
Merged

Adds silver background colour to inputs disabled type email, password, text#110
jdan merged 5 commits intojdan:mainfrom
lwkchan:patch-1

Conversation

@lwkchan
Copy link
Copy Markdown
Contributor

@lwkchan lwkchan commented Mar 12, 2021

Related to #109

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/jdan/98css/2i5DM6jW8tuJxy56dq2B1f25pT5q
✅ Preview: https://98css-git-fork-lwkchan-patch-1-jdan.vercel.app

@jdan
Copy link
Copy Markdown
Owner

jdan commented Mar 13, 2021

Awesome :) Wanna add an example to index.html.ejs?

@lwkchan lwkchan changed the title Adds silver background colour to inputs type email, password, text Adds silver background colour to inputs disabled type email, password, text Mar 13, 2021
@jdan
Copy link
Copy Markdown
Owner

jdan commented Mar 13, 2021

Hey Laura! Thanks for adding the example, this is close. Just one issue I wanted to raise is that you may need to modify the existing :disabled selector to prevent this text shadow

image

(I guess we only want the text shadow on button:disabled and :disabled + label )

Comment thread style.css Outdated
line-height: 2;
}

input[type="email"][disabled],
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be good to rely on :disabled instead of [disabled] but I am open to suggestion https://developer.mozilla.org/en-US/docs/Web/CSS/:disabled

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went for [disabled] to be consistent with what was above. But I do prefer :disabled as well, so will change this

@jdan
Copy link
Copy Markdown
Owner

jdan commented Mar 16, 2021

Love it thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants