Progress indicator (a.k.a. progress bar control)#170
Merged
chanagaray merged 2 commits intomainfrom Sep 21, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chanagaray
changed the title
chanagaray
force-pushed
the
progress-indicator
branch
from
f52b0d5 to
6e988bf
Compare
chanagaray
force-pushed
the
progress-indicator
branch
from
6e988bf to
3d0b8d9
Compare
jruales
reviewed
Sep 18, 2023
jruales
reviewed
Sep 18, 2023
chanagaray
force-pushed
the
progress-indicator
branch
from
3d0b8d9 to
798d502
Compare
chanagaray
force-pushed
the
progress-indicator
branch
from
798d502 to
2c2c084
Compare
TrudeEH
approved these changes
Sep 20, 2023
TrudeEH
left a comment
TrudeEH
left a comment
There was a problem hiding this comment.
The PR looks great to me, thank you for replying to the issue I opened.
jruales
approved these changes
Sep 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
I'm salvaging this PR from 2020 and this PR, as both were closed after the migration from
mastertomain.I ended up simplifying the implementation and solving a few issues such as the borders not being those seen on Windows 98 screenshots.
One thing that neither of those PRs have is a way to make the blue blocks discrete (there should never be half a block in the middle of a progress indicator). However, as long as the CSS round() function isn't implemented, I do not believe that there is a way to solve this and keep respecting the aspect ratio of the blocks in the segmented version of the progress bar.
Sadly I was unable to save the HTML
<progress>implementation, which would've been more semantically correct.I looked up screenshots and the blocks in the are sometimes 8x12 px with 2px separation OR 6x9 px with 2px separation. I have implemented only the 8x12 version at this time.