Skip to content

Add disabled styling for Maximize title bar buttons#190

Merged
vtlanglois merged 4 commits intojdan:mainfrom
vtlanglois:add-disabled-maximize-button-styling
Jan 28, 2024
Merged

Add disabled styling for Maximize title bar buttons#190
vtlanglois merged 4 commits intojdan:mainfrom
vtlanglois:add-disabled-maximize-button-styling

Conversation

@vtlanglois
Copy link
Copy Markdown
Collaborator

In this PR

  • Added icon/maximize-disabled.svg, based on a disabled Maximize title bar button1.
  • Added styling declaration for disabled Maximize buttons.
  • Added documentation example of disabled Maximize buttons

📈 Impact

With this additions, users will be able to style windows as if they cannot be maximize. This can be useful when users wish to:

  • recreate Windows 98 UIs, such as the Media Player or CD Player.
  • replicate Windows 98 functionality in their project, such as having a window be able to be maximized.
  • provide a visual aid that a window cannot be maximized.
Screenshot 2024-01-21 at 12 36 33 PM

Reasons for Drafting this PR

I have another PR related to title bar buttons up (#189). As that PR could cause merge conflicts with this PR and has changes that, if approved, need to be applied to for disabled maximize buttons to work as intended without English-text aria-labels, this will be a draft until action is done on that PR.

This prevents a possible bug from arising if work is not done to apply the changes in #189 to this PR.

📔 Dev Note

I tried looking for examples of the remaining 4 title bar buttons having a disabled state, but couldn't find concrete evidence of that in Windows 98.

Footnotes

  1. styling based on multimedia application UIs screenshots from this website: https://guidebookgallery.org/screenshots/win98

@vtlanglois vtlanglois self-assigned this Jan 21, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
98css ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2024 2:09am

Copy link
Copy Markdown
Owner

@jdan jdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Is it possible to apply a filter to the button to get the same effect? (Is it possible to apply this filter to other buttons/icons too?)

No need for my approval to merge these btw. Feel free to use your own discretion ✨

@vtlanglois vtlanglois marked this pull request as ready for review January 28, 2024 02:10
@vtlanglois
Copy link
Copy Markdown
Collaborator Author

Looks good! Is it possible to apply a filter to the button to get the same effect? (Is it possible to apply this filter to other buttons/icons too?)

No need for my approval to merge these btw. Feel free to use your own discretion ✨

Thanks!

I don't have experience in using filters on SVGs, but I could see it being possible. I could look into this on my free time, ofc no guarantees with work and all. Should this be made into an Issue in case another dev is able to implement this?

@vtlanglois vtlanglois merged commit 1f2e3db into jdan:main Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants