Removed --checkmark-top to fix multiline checkboxes#191
Merged
chanagaray merged 1 commit intojdan:mainfrom Jan 25, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #142
In this PR:
--checkmark-topand relatedtop:...code to fix multiline checkboxes1💭 Reasoning
As stated in #142, if a label was wrapped to be more than one line, the checkbox would be centered but not the checkmark.
The source of this issue was due to
--checkmark-topforcing atop: 3pxonto the checkmark1, which seemed to worked as intended until the label became multiline. When disabled, however, thetopdeclaration didn't seem to be doing anything to force the checkmark to appear in the right place.When removed, no visible changes occurred.
📈 Impact
Should this PR be accepted, this should prevent a noticeable visual bug from occurring.
📔 Dev Note
Does anyone know what a multiline checkbox would look like in W98? Couldn't find any examples of that, nor have I been able to get a VM going with W98 to check.
Footnotes
This fix was first reported by @psyklon-project here ↩ ↩2
Image from @metropolis-nostalgia ↩