Add slider#78
Merged
jdan merged 13 commits intojdan:masterfrom May 7, 2020
joaonunomota:input-range
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/jdan/98css/18kva91eu |
|
Deployment failed with the following error: |
Owner
|
Wonderful! Wanna rebase off master? I made a couple other changes that would be helpful to see in preview mode. |
Displays indicator as radio outline on Windows 10 Firefox 75
Owner
|
thanks for rebasing. this looks very handsome, and I really appreciate the attention to detail both in the implementation and in the docs. just one question inline before I merge. |
Owner
|
Thanks so much!! This is a fun one. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add styling to input[type="range"] to resemble windows 98 sliders (is missing ticks). Input can be further styled with
has-box-indicatorto replace default indicator with rectangular inidcator, and made vertical by wrapping it in a div with classis-vertical. Docs are updated to include slider component.Docs in chrome:
Docs in Firefox with indicators swapped:
Tested in latest Chrome, Firefox, Edge (does not work in IE)