Regression with new pkl backend

[Entze]

Upgrading from version 1.46.0 to 1.47.0, I've noticed a regression.

amends "package://github.com/jdx/hk/releases/download/v1.46.0/hk@1.46.0#/Config.pkl"
import "package://github.com/jdx/hk/releases/download/v1.46.0/hk@1.46.0#/Builtins.pkl"

local formatters = new Mapping<String, Step> {
  ["mise"] = Builtins.mise
  ["newlines"] = (Builtins.newlines) {
    types = List("text")
  }
  ["pkl_format"] = Builtins.pkl_format
  ["trailing_whitespace"] = (Builtins.trailing_whitespace) {
    types = List("text")
  }
  ["typstyle"] {
    glob = List("src/**/*.typ")
    check = "typstyle --check {{ files }}"
    fix = "typstyle --inplace {{ files }}"
  }
}

local checkers = new Mapping<String, Step> {
  ["pkl"] = Builtins.pkl
}

local linters = new Mapping<String, Step> {}

local baseHook = new Hook {
  steps {
    ["formatters"] = new Group {
        steps = formatters
    }
    ["checkers"] = new Group {
        steps = checkers
    }
  }
}

hooks {
  ["pre-commit"] = (baseHook) {
    fix = true
    stash = "git"
  }
  ["fix"] = (baseHook) {
    fix = true
  }
  ["check"] = baseHook
  ["lint"] {
    steps = linters
  }
}

$ hk validate

thread 'main' (40037) panicked at src/settings.rs:101:30:
Failed to load configuration: Failed to read config file: [REDACTED]/hk.pkl

Caused by:
    Failed to evaluate Pkl config at [REDACTED]/hk.pkl

    Error output:
    Eval error: cannot add property 'steps' to non-open class Group

Location:
    src/config.rs:614:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

By declaring the groups explicitly, I was able to fix the error.

amends "package://github.com/jdx/hk/releases/download/v1.47.0/hk@1.47.0#/Config.pkl"
import "package://github.com/jdx/hk/releases/download/v1.47.0/hk@1.47.0#/Builtins.pkl"

local formatters = new Mapping<String, Step> {
  ["mise"] = Builtins.mise
  ["newlines"] = (Builtins.newlines) {
    types = List("text")
  }
  ["pkl_format"] = Builtins.pkl_format
  ["trailing_whitespace"] = (Builtins.trailing_whitespace) {
    types = List("text")
  }
  ["typstyle"] {
    glob = List("src/**/*.typ")
    check = "typstyle --check {{ files }}"
    fix = "typstyle --inplace {{ files }}"
  }
}

local checkers = new Mapping<String, Step> {
  ["pkl"] = Builtins.pkl
}

local linters = new Mapping<String, Step> {}

local formattersGroup = new Group {
  steps = formatters
}

local checkersGroup = new Group {
  steps = checkers
}

local baseHook = new Hook {
  steps {
    ["formatters"] = formattersGroup
    ["checkers"] = checkersGroup
  }
}

hooks {
  ["pre-commit"] = (baseHook) {
    fix = true
    stash = "git"
  }
  ["fix"] = (baseHook) {
    fix = true
  }
  ["check"] = baseHook
  ["lint"] {
    steps = linters
  }
}

I suspect this is related to the new pkl backend. Supposedly, this can be fixed by falling back to Apple's pkl.

As this was only a "minor" release and I was under the assumption that hk released adhering semantic versioning, I'd label this as a regression. Please advise if you need anything further from me.

[jdx]

jdx/pklr#106