Attestation verification does not respect settings.url_replacements for "https://api.github.com"
#8846
Replies: 2 comments 3 replies
-
|
This requires a upstream change to fix, so I've opened an issue upstream: jdx/sigstore-verification#32. |
Beta Was this translation helpful? Give feedback.
-
|
I dug into this again against current The upstream blocker appears to be gone: the in-tree I am planning a narrow PR that centralizes this in
I will add unit coverage for simple/regex URL replacements so future sigstore call sites inherit the behavior. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
#8820 & #8495 added attestation verification, but the attestation verification doesn't respect
settings.url_replacements, leading to the confusing scenario where you can reroute a GitHub download but not it's verification.It feels like this is a bug, and that attestation verification should respect url_replacements.
You can see that the attestation client hard-codes the API URL:
https://github.com/jdx/sigstore-verification/blob/ea6fd37bb6aaf69a977f6f11419a59923e60d44e/src/api.rs#L76-L90
Beta Was this translation helpful? Give feedback.
All reactions