Skip to content

migrate: remove deprecated non-core plugins#1034

Merged
jdx merged 1 commit intomainfrom
deprecated-plugins
Dec 1, 2023
Merged

migrate: remove deprecated non-core plugins#1034
jdx merged 1 commit intomainfrom
deprecated-plugins

Conversation

@jdx
Copy link
Copy Markdown
Owner

@jdx jdx commented Nov 30, 2023

If rtx-nodejs (or other deprecated plugins) is installed it should be removed in favor of the core plugins

See discussion in https://github.com/jdx/rtx/issues/956

@jdx jdx enabled auto-merge (squash) November 30, 2023 23:59
@jdx jdx force-pushed the deprecated-plugins branch from 345c850 to aa04af1 Compare December 1, 2023 00:01
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1bd8b52) 87.24% compared to head (a4eedfc) 87.21%.

Files Patch % Lines
src/migrate.rs 87.80% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1034      +/-   ##
==========================================
- Coverage   87.24%   87.21%   -0.04%     
==========================================
  Files         133      133              
  Lines       11754    11780      +26     
==========================================
+ Hits        10255    10274      +19     
- Misses       1499     1506       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

If rtx-nodejs (or other deprecated plugins) is installed it should be removed in favor of the core plugins
@jdx jdx force-pushed the deprecated-plugins branch from aa04af1 to a4eedfc Compare December 1, 2023 00:02
@jdx jdx merged commit 9d72a46 into main Dec 1, 2023
@jdx jdx deleted the deprecated-plugins branch December 1, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant