Skip to content

node: added ability to install node without node-build#1035

Merged
jdx merged 1 commit intomainfrom
rm-node-build
Dec 1, 2023
Merged

node: added ability to install node without node-build#1035
jdx merged 1 commit intomainfrom
rm-node-build

Conversation

@jdx
Copy link
Copy Markdown
Owner

@jdx jdx commented Dec 1, 2023

#1028

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 180 lines in your changes are missing coverage. Please review.

Comparison is base (9d72a46) 87.21% compared to head (35971ac) 86.35%.

Files Patch % Lines
src/plugins/core/node.rs 43.35% 98 Missing ⚠️
src/plugins/core/node_build.rs 84.18% 37 Missing ⚠️
src/env.rs 30.95% 29 Missing ⚠️
src/cmd.rs 33.33% 10 Missing ⚠️
src/http.rs 84.00% 4 Missing ⚠️
src/plugins/core/python.rs 80.00% 1 Missing ⚠️
src/plugins/core/ruby.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
- Coverage   87.21%   86.35%   -0.87%     
==========================================
  Files         133      134       +1     
  Lines       11780    12171     +391     
==========================================
+ Hits        10274    10510     +236     
- Misses       1506     1661     +155     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdx jdx force-pushed the rm-node-build branch 6 times, most recently from 3da6eaa to 681e96b Compare December 1, 2023 06:09
@jdx jdx merged commit 8d24df2 into main Dec 1, 2023
@jdx jdx deleted the rm-node-build branch December 1, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant