Skip to content

shims: insert rtx PATH entries just before the shim directory#1082

Merged
jdx merged 3 commits intomainfrom
shim-insert-path
Dec 5, 2023
Merged

shims: insert rtx PATH entries just before the shim directory#1082
jdx merged 3 commits intomainfrom
shim-insert-path

Conversation

@jdx
Copy link
Copy Markdown
Owner

@jdx jdx commented Dec 5, 2023

Before, rtx would put the PATH entries at the front of PATH but that is too aggressive in some scenarios

Fixes https://github.com/jdx/rtx/issues/1061

jdx added 3 commits December 5, 2023 16:14
Before, rtx would put the PATH entries at the front of PATH but that is too aggressive in some scenarios

Fixes #1061
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f688de2) 79.96% compared to head (60bc670) 77.69%.

Files Patch % Lines
src/toolset/mod.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1082      +/-   ##
==========================================
- Coverage   79.96%   77.69%   -2.27%     
==========================================
  Files         134      135       +1     
  Lines       12521    12606      +85     
==========================================
- Hits        10012     9794     -218     
- Misses       2509     2812     +303     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdx jdx merged commit 8920713 into main Dec 5, 2023
@jdx jdx deleted the shim-insert-path branch December 5, 2023 23:05
@jdx jdx linked an issue Dec 6, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Differences in PATH treatment between asdf and rtx using shims mode rtx-activate: less aggressive PATH modifications

1 participant