Skip to content

node: default PATH to current PATH when compiling#1107

Merged
jdx merged 2 commits intomainfrom
node-fix
Dec 7, 2023
Merged

node: default PATH to current PATH when compiling#1107
jdx merged 2 commits intomainfrom
node-fix

Conversation

@jdx
Copy link
Copy Markdown
Owner

@jdx jdx commented Dec 7, 2023

Fixes #1106

Co-authored-by: Restyled.io <commits@restyled.io>
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f13c6bf) 87.40% compared to head (48d38d1) 87.37%.

Files Patch % Lines
src/cmd.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1107      +/-   ##
==========================================
- Coverage   87.40%   87.37%   -0.04%     
==========================================
  Files         137      137              
  Lines       12547    12551       +4     
==========================================
- Hits        10967    10966       -1     
- Misses       1580     1585       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 5 0 0.24s
✅ BASH bash-exec 19 0 0.05s
✅ BASH shellcheck 19 0 0.32s
✅ BASH shfmt 19 0 0 0.04s
✅ DOCKERFILE hadolint 5 0 0.12s
✅ EDITORCONFIG editorconfig-checker 465 0 0.34s
✅ JSON eslint-plugin-jsonc 7 0 0 0.99s
✅ JSON jsonlint 6 0 0.14s
✅ JSON prettier 7 0 0 0.64s
✅ JSON v8r 7 0 4.79s
✅ MARKDOWN markdownlint 13 0 0 2.72s
✅ MARKDOWN markdown-link-check 13 0 12.02s
✅ MARKDOWN markdown-table-formatter 13 0 0 0.35s
✅ PYTHON bandit 1 0 0.8s
✅ PYTHON black 1 0 0 0.59s
✅ PYTHON flake8 1 0 0.32s
✅ PYTHON isort 1 0 0 0.27s
✅ PYTHON mypy 1 0 2.0s
✅ PYTHON pylint 1 0 1.25s
✅ PYTHON pyright 1 0 5.46s
✅ PYTHON ruff 1 0 0 0.04s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 2.22s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY secretlint yes no 2.37s
✅ REPOSITORY syft yes no 0.5s
✅ REPOSITORY trivy-sbom yes no 0.95s
✅ REPOSITORY trufflehog yes no 4.22s
✅ RUBY rubocop 2 0 0 4.9s
✅ RUST clippy yes no 102.82s
✅ XML xmllint 5 0 0 0.04s
✅ YAML prettier 12 0 0 1.17s
✅ YAML v8r 12 0 12.02s
✅ YAML yamllint 12 0 0.31s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@jdx jdx merged commit a3676e4 into main Dec 7, 2023
@jdx jdx deleted the node-fix branch December 7, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when attempting to install certain nodejs versions

1 participant