Skip to content

devcontainer: minor fixes for nodesource and npm packages#1124

Merged
jdx merged 2 commits intojdx:mainfrom
jasisk:js/chore/devcontainer-fixes
Dec 8, 2023
Merged

devcontainer: minor fixes for nodesource and npm packages#1124
jdx merged 2 commits intojdx:mainfrom
jasisk:js/chore/devcontainer-fixes

Conversation

@jasisk
Copy link
Copy Markdown
Contributor

@jasisk jasisk commented Dec 8, 2023

  • nodesource is deprecating the old install script. Running it right now introduces a 60s delay and will eventually break
  • a few npm packages are required globally to run the just commands—I've set them to the latest versions as of today

@jdx jdx enabled auto-merge (squash) December 8, 2023 04:30
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (66b4799) 77.66% compared to head (78d94da) 85.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1124      +/-   ##
==========================================
+ Coverage   77.66%   85.22%   +7.56%     
==========================================
  Files         137      137              
  Lines       12593    12593              
==========================================
+ Hits         9780    10733     +953     
+ Misses       2813     1860     -953     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdx jdx merged commit 88ee405 into jdx:main Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants