Skip to content

refactor: simplified stdout/stderr mocking in tests#1163

Merged
jdx merged 1 commit intomainfrom
out-refactor
Dec 13, 2023
Merged

refactor: simplified stdout/stderr mocking in tests#1163
jdx merged 1 commit intomainfrom
out-refactor

Conversation

@jdx
Copy link
Copy Markdown
Owner

@jdx jdx commented Dec 13, 2023

No description provided.

@jdx jdx enabled auto-merge (squash) December 13, 2023 20:50
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (13255b1) 85.76% compared to head (5a74547) 85.70%.

❗ Current head 5a74547 differs from pull request most recent head 478450a. Consider uploading reports for the commit 478450a to get more accurate results

Files Patch % Lines
src/cli/sync/node.rs 0.00% 10 Missing ⚠️
src/cli/asdf.rs 70.00% 3 Missing ⚠️
src/cli/ls_remote.rs 57.14% 3 Missing ⚠️
src/cli/doctor.rs 83.33% 2 Missing ⚠️
src/cli/alias/ls.rs 66.66% 1 Missing ⚠️
src/cli/direnv/activate.rs 0.00% 1 Missing ⚠️
src/cli/direnv/mod.rs 83.33% 1 Missing ⚠️
src/cli/env.rs 85.71% 1 Missing ⚠️
src/cli/ls.rs 90.90% 1 Missing ⚠️
src/cli/mod.rs 97.95% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1163      +/-   ##
==========================================
- Coverage   85.76%   85.70%   -0.06%     
==========================================
  Files         139      138       -1     
  Lines       12809    12742      -67     
==========================================
- Hits        10985    10920      -65     
+ Misses       1824     1822       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 13, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 5 0 0.13s
✅ BASH bash-exec 19 0 0.06s
✅ BASH shellcheck 19 0 0.46s
✅ BASH shfmt 19 0 0 0.04s
✅ DOCKERFILE hadolint 7 0 0.28s
✅ EDITORCONFIG editorconfig-checker 472 0 0.84s
✅ JSON eslint-plugin-jsonc 7 0 0 1.2s
✅ JSON jsonlint 6 0 0.15s
✅ JSON prettier 7 0 0 0.65s
✅ JSON v8r 7 0 4.22s
✅ MARKDOWN markdownlint 13 0 0 2.99s
✅ MARKDOWN markdown-link-check 13 0 11.68s
✅ MARKDOWN markdown-table-formatter 13 0 0 0.41s
✅ PYTHON bandit 1 0 0.8s
✅ PYTHON black 1 0 0 0.87s
✅ PYTHON flake8 1 0 0.34s
✅ PYTHON isort 1 0 0 0.3s
✅ PYTHON mypy 1 0 1.98s
✅ PYTHON pylint 1 0 1.31s
✅ PYTHON pyright 1 0 5.5s
✅ PYTHON ruff 1 0 0 0.04s
✅ REPOSITORY dustilock yes no 0.03s
✅ REPOSITORY gitleaks yes no 2.61s
✅ REPOSITORY git_diff yes no 0.04s
✅ REPOSITORY secretlint yes no 2.27s
✅ REPOSITORY syft yes no 0.8s
✅ REPOSITORY trivy-sbom yes no 0.97s
✅ REPOSITORY trufflehog yes no 2.93s
✅ RUBY rubocop 2 0 0 5.03s
✅ RUST clippy yes no 103.34s
✅ XML xmllint 5 0 0 0.04s
✅ YAML prettier 12 0 0 1.32s
✅ YAML v8r 12 0 14.16s
✅ YAML yamllint 12 0 0.34s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@jdx jdx merged commit f83a556 into main Dec 13, 2023
@jdx jdx deleted the out-refactor branch December 13, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant