Skip to content

completions: complete setting names#1166

Merged
jdx merged 1 commit intomainfrom
completion-settings
Dec 13, 2023
Merged

completions: complete setting names#1166
jdx merged 1 commit intomainfrom
completion-settings

Conversation

@jdx
Copy link
Copy Markdown
Owner

@jdx jdx commented Dec 13, 2023

#97

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 13, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 5 0 0.09s
✅ BASH bash-exec 19 0 0.05s
✅ BASH shellcheck 19 0 0.37s
✅ BASH shfmt 19 0 0 0.04s
✅ DOCKERFILE hadolint 7 0 0.15s
✅ EDITORCONFIG editorconfig-checker 472 0 0.35s
✅ JSON eslint-plugin-jsonc 7 0 0 0.97s
✅ JSON jsonlint 6 0 0.13s
✅ JSON prettier 7 0 0 0.64s
✅ JSON v8r 7 0 4.32s
✅ MARKDOWN markdownlint 13 0 0 2.63s
✅ MARKDOWN markdown-link-check 13 0 14.55s
✅ MARKDOWN markdown-table-formatter 13 0 0 0.38s
✅ PYTHON bandit 1 0 0.69s
✅ PYTHON black 1 0 0 0.58s
✅ PYTHON flake8 1 0 0.4s
✅ PYTHON isort 1 0 0 0.27s
✅ PYTHON mypy 1 0 2.01s
✅ PYTHON pylint 1 0 1.2s
✅ PYTHON pyright 1 0 5.68s
✅ PYTHON ruff 1 0 0 0.05s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 2.2s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY secretlint yes no 2.77s
✅ REPOSITORY syft yes no 0.36s
✅ REPOSITORY trivy-sbom yes no 1.03s
✅ REPOSITORY trufflehog yes no 3.58s
✅ RUBY rubocop 2 0 0 4.73s
✅ RUST clippy yes no 104.78s
✅ XML xmllint 5 0 0 0.03s
✅ YAML prettier 12 0 0 1.23s
✅ YAML v8r 12 0 10.73s
✅ YAML yamllint 12 0 0.3s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (631c53d) 85.73% compared to head (6b5cfd8) 81.82%.

Files Patch % Lines
src/cli/settings/set.rs 50.00% 2 Missing ⚠️
src/cli/settings/get.rs 66.66% 1 Missing ⚠️
src/cli/settings/unset.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
- Coverage   85.73%   81.82%   -3.91%     
==========================================
  Files         138      138              
  Lines       12769    12793      +24     
==========================================
- Hits        10947    10468     -479     
- Misses       1822     2325     +503     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdx jdx force-pushed the completion-settings branch from 52977bf to 87b1601 Compare December 13, 2023 21:57
@jdx jdx enabled auto-merge (squash) December 13, 2023 21:58
@jdx jdx force-pushed the completion-settings branch from 87b1601 to 6b5cfd8 Compare December 13, 2023 22:21
@jdx jdx merged commit fff00ef into main Dec 13, 2023
@jdx jdx deleted the completion-settings branch December 13, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant