Skip to content

use: show warning if setting a version that will not be used#1171

Merged
jdx merged 1 commit intomainfrom
use-warning
Dec 14, 2023
Merged

use: show warning if setting a version that will not be used#1171
jdx merged 1 commit intomainfrom
use-warning

Conversation

@jdx
Copy link
Copy Markdown
Owner

@jdx jdx commented Dec 14, 2023

e.g.: rtx use -g node@18 if there is a local .rtx.toml with node already defined

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 14, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 5 0 0.09s
✅ BASH bash-exec 19 0 0.05s
✅ BASH shellcheck 19 0 0.31s
✅ BASH shfmt 19 0 0 0.04s
✅ DOCKERFILE hadolint 7 0 0.14s
✅ EDITORCONFIG editorconfig-checker 470 0 0.34s
✅ JSON eslint-plugin-jsonc 7 0 0 1.02s
✅ JSON jsonlint 6 0 0.1s
✅ JSON prettier 7 0 0 0.68s
✅ JSON v8r 7 0 4.54s
✅ MARKDOWN markdownlint 13 0 0 2.95s
✅ MARKDOWN markdown-link-check 13 0 11.57s
✅ MARKDOWN markdown-table-formatter 13 0 0 0.4s
✅ PYTHON bandit 1 0 0.85s
✅ PYTHON black 1 0 0 1.32s
✅ PYTHON flake8 1 0 0.31s
✅ PYTHON isort 1 0 0 0.29s
✅ PYTHON mypy 1 0 2.03s
✅ PYTHON pylint 1 0 1.22s
✅ PYTHON pyright 1 0 5.3s
✅ PYTHON ruff 1 0 0 0.05s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 2.24s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY secretlint yes no 2.09s
✅ REPOSITORY syft yes no 0.61s
✅ REPOSITORY trivy-sbom yes no 0.83s
✅ REPOSITORY trufflehog yes no 4.78s
✅ RUBY rubocop 2 0 0 4.67s
✅ RUST clippy yes no 103.12s
✅ XML xmllint 5 0 0 0.04s
✅ YAML prettier 12 0 0 1.27s
✅ YAML v8r 12 0 12.35s
✅ YAML yamllint 12 0 0.35s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f3c32cb) 84.24% compared to head (84c5782) 79.25%.

Files Patch % Lines
src/cli/use.rs 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
- Coverage   84.24%   79.25%   -5.00%     
==========================================
  Files         136      136              
  Lines       12831    12852      +21     
==========================================
- Hits        10810    10186     -624     
- Misses       2021     2666     +645     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdx jdx force-pushed the use-warning branch 4 times, most recently from 3e58555 to 5382bf2 Compare December 14, 2023 01:45
@jdx jdx marked this pull request as ready for review December 14, 2023 01:45
e.g.: `rtx use -g node@18` if there is a local .rtx.toml with node already defined
@jdx jdx merged commit 2131936 into main Dec 14, 2023
@jdx jdx deleted the use-warning branch December 14, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant