Skip to content

cli-parser: consolidate CLI parsing logic#1237

Merged
jdx merged 1 commit intomainfrom
warn-on-missing
Dec 21, 2023
Merged

cli-parser: consolidate CLI parsing logic#1237
jdx merged 1 commit intomainfrom
warn-on-missing

Conversation

@jdx
Copy link
Copy Markdown
Owner

@jdx jdx commented Dec 21, 2023

No more custom parsing so now things like rtx i -fvv works correctly

No more custom parsing so now things like `rtx i -fvv` works correctly
@jdx jdx enabled auto-merge (squash) December 21, 2023 18:26
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (189221c) 82.42% compared to head (695a9ef) 80.40%.

Files Patch % Lines
src/config/settings.rs 75.00% 7 Missing ⚠️
src/cli/mod.rs 66.66% 4 Missing ⚠️
src/env.rs 0.00% 2 Missing ⚠️
src/logger.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
- Coverage   82.42%   80.40%   -2.03%     
==========================================
  Files         140      140              
  Lines       13187    13174      -13     
==========================================
- Hits        10870    10592     -278     
- Misses       2317     2582     +265     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 5 0 0.13s
✅ BASH bash-exec 20 0 0.07s
✅ BASH shellcheck 20 0 0.62s
✅ BASH shfmt 20 0 0 0.04s
✅ DOCKERFILE hadolint 7 0 0.15s
✅ EDITORCONFIG editorconfig-checker 453 0 0.36s
✅ JSON eslint-plugin-jsonc 7 0 0 1.01s
✅ JSON jsonlint 6 0 0.11s
✅ JSON prettier 7 0 0 0.48s
✅ JSON v8r 7 0 4.41s
✅ MARKDOWN markdownlint 13 0 0 2.74s
✅ MARKDOWN markdown-link-check 13 0 11.18s
✅ MARKDOWN markdown-table-formatter 13 0 0 0.4s
✅ PYTHON bandit 1 0 0.74s
✅ PYTHON black 1 0 0 0.56s
✅ PYTHON flake8 1 0 0.28s
✅ PYTHON isort 1 0 0 0.3s
✅ PYTHON mypy 1 0 1.95s
✅ PYTHON pylint 1 0 1.27s
✅ PYTHON pyright 1 0 5.31s
✅ PYTHON ruff 1 0 0 0.07s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 2.27s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY secretlint yes no 2.3s
✅ REPOSITORY syft yes no 0.57s
✅ REPOSITORY trivy-sbom yes no 1.15s
✅ REPOSITORY trufflehog yes no 4.5s
✅ RUBY rubocop 2 0 0 4.93s
✅ RUST clippy yes no 109.64s
✅ XML xmllint 5 0 0 0.04s
✅ YAML prettier 13 0 0 1.21s
✅ YAML v8r 13 0 12.31s
✅ YAML yamllint 13 0 0.34s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@jdx jdx merged commit 8893991 into main Dec 21, 2023
@jdx jdx deleted the warn-on-missing branch December 21, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant