Skip to content

clean up logging env var logic#850

Merged
jdx merged 2 commits intomainfrom
env
Aug 27, 2023
Merged

clean up logging env var logic#850
jdx merged 2 commits intomainfrom
env

Conversation

@jdx
Copy link
Copy Markdown
Owner

@jdx jdx commented Aug 27, 2023

Main purpose is to ensure that RTX_DEBUG/RTX_TRACE are available in plugins

jdx added 2 commits August 27, 2023 14:33
if --trace is set, automatically sets RTX_DEBUG=1 in addition to RTX_TRACE=1.
Also sets RTX_LOG_LEVEL when --trace/--debug is set
Main purpose is to ensure that RTX_DEBUG/RTX_TRACE are available in plugins
@jdx jdx changed the title env set logging env vars clean up log env var logic Aug 27, 2023
@jdx jdx enabled auto-merge (squash) August 27, 2023 19:34
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 27, 2023

Codecov Report

Patch coverage: 59.25% and project coverage change: -0.05% ⚠️

Comparison is base (d5abfa6) 87.67% compared to head (190bbf4) 87.62%.

❗ Current head 190bbf4 differs from pull request most recent head 732f54a. Consider uploading reports for the commit 732f54a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
- Coverage   87.67%   87.62%   -0.05%     
==========================================
  Files         132      132              
  Lines       11541    11552      +11     
==========================================
+ Hits        10118    10123       +5     
- Misses       1423     1429       +6     
Files Changed Coverage Δ
src/env.rs 86.43% <57.69%> (-1.48%) ⬇️
src/cli/hook_env.rs 93.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdx jdx changed the title set logging env vars clean up log env var logic clean up logging env var logic Aug 27, 2023
@jdx jdx merged commit 1ae7357 into main Aug 27, 2023
@jdx jdx deleted the env branch August 27, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant