Skip to content

fix: Always return a list on 'rtx ls <plugin> --json'#896

Merged
jdx merged 1 commit intojdx:mainfrom
booniepepper:main
Sep 14, 2023
Merged

fix: Always return a list on 'rtx ls <plugin> --json'#896
jdx merged 1 commit intojdx:mainfrom
booniepepper:main

Conversation

@booniepepper
Copy link
Copy Markdown
Contributor

closes #882

@booniepepper booniepepper force-pushed the main branch 3 times, most recently from a0ed625 to a2a5729 Compare September 14, 2023 19:26
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +2.11% 🎉

Comparison is base (c6d59d7) 85.33% compared to head (c8cc13e) 87.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
+ Coverage   85.33%   87.45%   +2.11%     
==========================================
  Files         132      132              
  Lines       11581    11590       +9     
==========================================
+ Hits         9883    10136     +253     
+ Misses       1698     1454     -244     
Files Changed Coverage Δ
src/cli/ls.rs 93.72% <100.00%> (+0.21%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


type RuntimeRow = (Arc<Tool>, ToolVersion, Option<ToolSource>);

impl From<RuntimeRow> for JSONToolVersion {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so clean!

@jdx jdx merged commit 2545f45 into jdx:main Sep 14, 2023
jdx pushed a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let rtx ls --json always return an array

2 participants