Skip to content

plugin-uninstall: added --purge flag#975

Merged
jdx merged 1 commit intomainfrom
purge
Nov 3, 2023
Merged

plugin-uninstall: added --purge flag#975
jdx merged 1 commit intomainfrom
purge

Conversation

@jdx
Copy link
Copy Markdown
Owner

@jdx jdx commented Nov 3, 2023

this changes the behavior of uninstalls to now no longer remove installed plugins, see: https://github.com/jdx/rtx/issues/942

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2796c45) 87.43% compared to head (e521f1e) 87.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #975      +/-   ##
==========================================
- Coverage   87.43%   87.41%   -0.03%     
==========================================
  Files         132      132              
  Lines       11591    11613      +22     
==========================================
+ Hits        10135    10151      +16     
- Misses       1456     1462       +6     
Files Coverage Δ
src/cli/plugins/install.rs 92.04% <100.00%> (+0.09%) ⬆️
src/cli/plugins/ls.rs 93.75% <100.00%> (ø)
src/config/mod.rs 93.29% <100.00%> (ø)
src/plugins/external_plugin.rs 85.92% <100.00%> (-0.24%) ⬇️
src/plugins/mod.rs 75.22% <100.00%> (ø)
src/runtime_symlinks.rs 100.00% <100.00%> (ø)
src/toolset/tool_version_list.rs 96.22% <100.00%> (ø)
src/cli/plugins/uninstall.rs 96.15% <75.00%> (-3.85%) ⬇️
src/tool.rs 92.02% <79.16%> (-1.05%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdx jdx enabled auto-merge (squash) November 3, 2023 22:16
@jdx jdx disabled auto-merge November 3, 2023 22:17
@jdx jdx merged commit 5228fcf into main Nov 3, 2023
@jdx jdx deleted the purge branch November 3, 2023 22:17
jdx pushed a commit that referenced this pull request Apr 9, 2024
Co-authored-by: James Hegedus <jthegedus@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant