fix(nushell): Use extern-wrapped instead of def-env and $env instead of let-env#981
Merged
fix(nushell): Use extern-wrapped instead of def-env and $env instead of let-env#981
Conversation
Should fix https://github.com/jdx/rtx/issues/514 Requires nushell 0.86, which released three weeks ago: https://www.nushell.sh/blog/2023-10-17-nushell_0_86.html#unified-command-definitions
`let-env` was removed in Nushell 0.83.0: https://www.nushell.sh/blog/2023-07-25-nushell_0_83.html#breaking-changes See https://github.com/jdx/rtx/issues/960 for more details
Nezteb
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #981 +/- ##
=======================================
Coverage 87.41% 87.41%
=======================================
Files 132 132
Lines 11613 11613
=======================================
Hits 10151 10151
Misses 1462 1462
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix https://github.com/jdx/rtx/issues/514 and https://github.com/jdx/rtx/issues/960.
My original fix was to use
extern-wrapped, but that will be deprecated in the next release of Nushell, so I opted fordef --wrappedwhich was added in nushell 0.86 released three weeks ago.If you want more backstory, see this thread in the Nushell DIscord.