Skip to content

added confirmation dialog when installing plugins#812

Merged
jdx merged 1 commit intomainfrom
global-ls
Aug 17, 2023
Merged

added confirmation dialog when installing plugins#812
jdx merged 1 commit intomainfrom
global-ls

Conversation

@jdx
Copy link
Copy Markdown
Owner

@jdx jdx commented Aug 16, 2023

Fixes #790

@jdx jdx enabled auto-merge (squash) August 16, 2023 23:52
@jdx jdx force-pushed the global-ls branch 2 times, most recently from cc78ecf to 2a08316 Compare August 17, 2023 00:39
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 90.13% and project coverage change: -2.15% ⚠️

Comparison is base (3986e9f) 87.63% compared to head (440d6e3) 85.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
- Coverage   87.63%   85.49%   -2.15%     
==========================================
  Files         130      131       +1     
  Lines       11416    11462      +46     
==========================================
- Hits        10004     9799     -205     
- Misses       1412     1663     +251     
Files Changed Coverage Δ
src/config/config_file/rtx_toml.rs 82.75% <0.00%> (-0.12%) ⬇️
src/cli/mod.rs 91.04% <75.00%> (-1.27%) ⬇️
src/config/settings.rs 92.45% <83.33%> (-0.27%) ⬇️
src/plugins/external_plugin.rs 86.18% <84.84%> (-0.34%) ⬇️
src/plugins/mod.rs 72.56% <93.10%> (+10.21%) ⬆️
src/cli/args/yes.rs 100.00% <100.00%> (ø)
src/cli/install.rs 87.85% <100.00%> (+1.61%) ⬆️
src/cli/ls_remote.rs 97.05% <100.00%> (-0.95%) ⬇️
src/cli/plugins/install.rs 91.95% <100.00%> (-0.76%) ⬇️
src/cli/settings/unset.rs 96.96% <100.00%> (+0.09%) ⬆️
... and 3 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdx jdx disabled auto-merge August 17, 2023 00:49
@jdx jdx merged commit 136d509 into main Aug 17, 2023
@jdx jdx deleted the global-ls branch August 17, 2023 01:35
jdx pushed a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add security warnings when installing plugins

1 participant