Fix matchWebGLToCanvasSize not setting to false #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreylanters
approved these changes
May 29, 2023
leomav
force-pushed
the
fix_matchWebGLToCanvasSize
branch
from
c5f1ff0 to
42bd04d
Compare
Contributor
Author
|
@jeffreylanters Sorry for that, i updated the PR cause I hadn't sing my commits :) |
added 2 commits
May 30, 2023 13:19
Signed-off-by: Leonidas Mavrotas <leo.mav.8@gmail.com>
Signed-off-by: Leonidas Mavrotas <leo.mav.8@gmail.com>
leomav
force-pushed
the
fix_matchWebGLToCanvasSize
branch
from
42bd04d to
6605893
Compare
Contributor
Author
|
@jeffreylanters finally managed to add verification correctly this time. Sorry for wasting time, that was the first time doing that. |
Owner
|
Hi Leonidas! Thank you for your pull request. Very sharp, this was indeed unintended behaviour. I'll merge it right away. 🦾 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we try to fix a matchWebGLToCanvasSize issue. This prop was always set to true event if we set it to false via . That's because in /hooks/use-unity-arguments.ts the matchWebGLToCanvasSize was being set with an OR operator which was always resulting to true.
Here is a screenshot of the only in-code change applied. By checking if the type is boolean we make sure that no other types like 'string' or 'undefined' are coming in, but if so, true should be the default value.