This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Prevent mismatches between code delta and jacoco data - Issue #467 #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
============================================
+ Coverage 72.66% 72.78% +0.11%
- Complexity 1010 1014 +4
============================================
Files 87 87
Lines 3754 3770 +16
Branches 436 437 +1
============================================
+ Hits 2728 2744 +16
Misses 878 878
Partials 148 148
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
uhafner
approved these changes
Sep 28, 2022
plugin/src/main/java/io/jenkins/plugins/coverage/model/CodeDeltaCalculator.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/jenkins/plugins/coverage/model/CodeDeltaCalculator.java
Outdated
Show resolved
Hide resolved
# Conflicts: # plugin/src/main/java/io/jenkins/plugins/coverage/model/CodeDeltaCalculator.java # plugin/src/test/java/io/jenkins/plugins/coverage/model/CodeDeltaCalculatorTest.java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an additional check to prevent exception in case of mismatches between the calculated code delta and the Jacoco coverage data.
This prevents the bug from issue #467.
After an unexpected behavior has been detected, all caluclations based on the code delta are skipped and the error is logged.