[JENKINS-57557] Add integration test with github-branch-source #1071
Conversation
fcojfernandez
changed the title
|
|
||
| private Option<Descriptor<T>> lookupDescriptor(String symbol, CNode config) { | ||
| return getDescriptors() | ||
| .filter(descriptor -> findByPreferredSymbol(descriptor, symbol) || findBySymbols(descriptor, symbol, config)) |
There was a problem hiding this comment.
Actually this is the correct formatting: https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/.idea/codeStyles/Project.xml#L89
So please, revert the revert 😆
There was a problem hiding this comment.
Perhaps not, we should take the styling fix in a separate PR :)
There was a problem hiding this comment.
The format change was made automatically by IntelliJ. My vote is always to make format changes in separate PRs, but as your preference.
|
@fcojfernandez I can see also github-branch-source-plugin #247. Does it make sense to repeat the test in both plugins? Which is the usual strategy? |
|
@varyvol AFAIK, there is no strategy. I made the decision to add both tests since there was none. This way we can check:
|
|
Meant to reply yesterday saying I'll merge it today, sorry. Done now |
|
@timja thanks! |
5 participants
See JENKINS-57557. configuration-as-code is compatible with the last version of github-branch-sources. This PR adds an integration test to check possible future issues.
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.
@varyvol @MRamonLeon @alecharp @rsandell
@timja @Casz