Validate external-workspace-manager demo with the integrations framework #1110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
approved these changes
Oct 3, 2019
|
Needs merge conflict fix |
|
@v1v looks like this PR got duplicated, and the fix is already integrated. Should we just close it? |
timja
approved these changes
Oct 3, 2019
|
aha, although the scope was something I missed when I created the PR at that time, I'm happy to close it and move the fix of the dependency scope in another of the other lovely PRs I created recently :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a consequence of #1055 let's move each demos in independent PRs to track all the required dependencies.
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.