Skip to content

Conversation

@ocristian
Copy link
Contributor

Setting the project description and URL to point to Github.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

Setting the project description and URL to point to Github.
@timja timja added the chore a PR that adds to maintenance - used by Release Drafter label Oct 4, 2019
@oleg-nenashev
Copy link
Member

+0 from me. It makes sense to have something in the root POM, but it may also cause confusion if somebody decides to improve the description later

@ocristian
Copy link
Contributor Author

Hi @Casz / @oleg-nenashev.
Thanks for your comments.
Please let me know if there is anything else I can do here. 👍

@jetersen
Copy link
Member

jetersen commented Oct 9, 2019

Perhaps remove the description/url on inside the plugin/pom.xml file? so it will use the parent pom one

@jetersen jetersen merged commit daefe4e into jenkinsci:master Oct 9, 2019
@oleg-nenashev
Copy link
Member

oops, I missed the last commit. It was a bad idea, metadata fields in pom.xml are not inherited from Parent POMs. It caused #1206

@jetersen
Copy link
Member

jetersen commented Nov 22, 2019

We could force it in the update center? 🤔

@oleg-nenashev
Copy link
Member

You mean defaulting to README if nothing is specified?

@jetersen
Copy link
Member

That is also a good option.
I was thinking more along the lines of https://github.com/jenkins-infra/update-center2/blob/master/src/main/resources/wiki-overrides.properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a PR that adds to maintenance - used by Release Drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants