Skip to content

Conversation

@johnpneumann
Copy link
Contributor

Encrypts the client secret and uses HudsonTestCase to get around mocking out Secret.

@samrocketman
Copy link
Member

This looks OK to me +2. I'll leave it open a bit for other interested eyeballs. I'd say this supersedes PR #50 and fixes [JENKINS-28319].

Please amend your commit message to include [JENKINS-28319] so it is more clear when using git log.

@johnpneumann
Copy link
Contributor Author

Amended the commit message. Thanks @samrocketman.

@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@johnpneumann
Copy link
Contributor Author

@samrocketman - Just checking on the status of this. Don't want it to get stale.

@samrocketman
Copy link
Member

Ah, thanks for the reminder. I'll focus on it this weekend (or evenings before the weekend when I get time).

@samrocketman
Copy link
Member

I have tested this. Works well. Secret.fromString() does the right thing so no migration is required.

@samrocketman samrocketman merged commit 72fd51a into jenkinsci:master Apr 29, 2016
@johnpneumann
Copy link
Contributor Author

Thank you sir.

@johnpneumann johnpneumann deleted the JENKINS-28319_encrypt_client_secret branch April 30, 2016 13:11
@samrocketman
Copy link
Member

I plan to release this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants