Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually entered repository source #131

Merged
merged 4 commits into from
Jul 21, 2016

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Jul 21, 2016

@reviewbybees

Allows to enter manually a repository to notify.

This is useful when you are working with a pipeline cloning multiple repositories and you want to notify only one of them on a specific SHA.


This change is Reviewable

@Vlatombe Vlatombe force-pushed the manually_entered_repository_source branch from 32dc5fb to 4ae71ca Compare July 21, 2016 09:57
@@ -0,0 +1,3 @@
<div>
A GitHub repository URL.
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line

@ghost
Copy link

ghost commented Jul 21, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@Vlatombe
Copy link
Member Author

@KostyaSha added the missing newlines

@lanwen
Copy link
Member

lanwen commented Jul 21, 2016

Please add a little unit test

@lanwen
Copy link
Member

lanwen commented Jul 21, 2016

src/main/java/org/jenkinsci/plugins/github/status/sources/ManuallyEnteredRepositorySource.java, line 41 [r2] (raw file):

                    return name.resolve();
                } else {
                    listener.getLogger().println("Unable to match " + url + " with a GitHub repository.");

logger can use formatting to avoid string concatenation via +


Comments from Reviewable

@lanwen
Copy link
Member

lanwen commented Jul 21, 2016

Reviewed 1 of 4 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions.


Comments from Reviewable

@Vlatombe
Copy link
Member Author

Vlatombe commented Jul 21, 2016

I have added a test when url cannot be converted into a repository name. However adding more coverage looks complicated because would need Jenkins rule and a valid connection to GitHub to resolve to a GHRepository.

@lanwen lanwen merged commit 6b10f5a into jenkinsci:master Jul 21, 2016
@Vlatombe Vlatombe deleted the manually_entered_repository_source branch July 21, 2016 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants