-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually entered repository source #131
Manually entered repository source #131
Conversation
32dc5fb
to
4ae71ca
Compare
@@ -0,0 +1,3 @@ | |||
<div> | |||
A GitHub repository URL. | |||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
@KostyaSha added the missing newlines |
Please add a little unit test |
src/main/java/org/jenkinsci/plugins/github/status/sources/ManuallyEnteredRepositorySource.java, line 41 [r2] (raw file):
logger can use formatting to avoid string concatenation via + Comments from Reviewable |
Reviewed 1 of 4 files at r1, 3 of 3 files at r2. Comments from Reviewable |
I have added a test when url cannot be converted into a repository name. However adding more coverage looks complicated because would need Jenkins rule and a valid connection to GitHub to resolve to a GHRepository. |
@reviewbybees
Allows to enter manually a repository to notify.
This is useful when you are working with a pipeline cloning multiple repositories and you want to notify only one of them on a specific SHA.
This change is