Skip to content

Conversation

@MarkEWaite
Copy link
Contributor

Use jenkins.baseline to match archetype

The Jenkins plugin archetype uses jenkins.baseline to prevent inconsistencies between the minimum required Jenkins version and the Jenkins plugin bill of materials version. Use the same technique in this plugin.

Testing done

Confirmed that compilation passes. Will rely on ci.jenkins.io to check automated tests. Behavior preserving transformation.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

The Jenkins plugin archetype uses jenkins.baseline to prevent
inconsistencies between the minimum required Jenkins version and the
Jenkins plugin bill of materials version.  Use the same technique in
this plugin.
@MarkEWaite MarkEWaite requested a review from a team as a code owner November 23, 2024 02:13
Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Mark! 👍

Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@gounthar gounthar merged commit bf5f389 into jenkinsci:master Nov 23, 2024
17 checks passed
@MarkEWaite MarkEWaite deleted the use-jenkins-baseline branch March 26, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants