Support Remote jobs in Folders #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a generateJobPath() helper function which turns job names into encoded job names. Job names are split on '/', each part is run through encodeValue(), then the resulting encoded parts are joined by "/job/". All instances where encodeValue(job) was used to build a job URL have been replaced with calls to generateJobPath(). A new test was added to handle the case where a job is in a folder.
Member
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
@eliranshlomo, this appears to be identical to #16, including the commit message. Is this what you intended? |
Author
|
No, pushed the wrong button. |
wincrasher
approved these changes
Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a generateJobPath() helper function which turns job
names into encoded job names. Job names are split on '/', each part is
run through encodeValue(), then the resulting encoded parts are joined
by "/job/". All instances where encodeValue(job) was used to build a job
URL have been replaced with calls to generateJobPath().
A new test was added to handle the case where a job is in a folder.