Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import java.io.Serializable;
import javax.net.ssl.*;
import java.net.URL;
import java.net.URLConnection;
import java.security.KeyManagementException;
import java.security.NoSuchAlgorithmException;
import java.security.SecureRandom;
Expand Down Expand Up @@ -219,25 +220,27 @@

// check that the host is reachable
try {
HttpsURLConnection conn = (HttpsURLConnection) host.openConnection();
try {
makeConnectionTrustAllCertificates(conn, trustAllCertificates);
} catch (NoSuchAlgorithmException | KeyManagementException e) {
return FormValidation.error(e, "A key management error occurred.");
URLConnection conn = host.openConnection();
if (conn instanceof HttpsURLConnection sslConn) {
try {
makeConnectionTrustAllCertificates(sslConn, trustAllCertificates);
} catch (NoSuchAlgorithmException | KeyManagementException e) {
return FormValidation.error(e, "A key management error occurred.");
}
}
conn.setConnectTimeout(5000);
conn.connect();

if (trustAllCertificates) {
return FormValidation.warning(
"Connection established! Accepting all certificates is potentially unsafe."
);
}
} catch (Exception e) {
return FormValidation.warning("Address looks good, but a connection could not be established.");
return FormValidation.warning(e, "Address looks good, but a connection could not be established.");
}

return FormValidation.ok();
return FormValidation.ok(host + " is reachable.");

Check warning on line 243 in src/main/java/org/jenkinsci/plugins/ParameterizedRemoteTrigger/RemoteJenkinsServer.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered lines

Lines 223-243 are not covered by tests
}

public static List<Auth2Descriptor> getAuth2Descriptors() {
Expand Down