-
Notifications
You must be signed in to change notification settings - Fork 10
GSoC 2024 - 2D visualization for small molecules #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I uploaded the figure in the images folder and reference it currently from there in the same style that some figures are referenced in Workshop and some other blog posts |
Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com>
Added RDKit ref Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com>
typo error an/a Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com>
Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com>
typo error in shoutout Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com>
Addition of google opensource link Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks, @talagayev! I left only a few small suggestions for adding relevant links and a couple of grammatical fixes.
I'm also going to copy your mentors (@cbouy, @richardjgowers, and @yuxuanzhuang) into this PR to see if they have any feedback.
|
@jennaswa thanks for looking and reviewing the PR and adding the links + fixing the grammatical errors, sorry for them, thought I checked all of them 😿 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions from me 👍
Adjusted code to widget Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com>
Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com>
Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com>
Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com>
removed separate import of mdonatello
Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com>
Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com>
Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com>
Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com>
removed mention of stable version
Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com>
Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com>
Separated into separate bullet points the features
Adjusted the wording in the code restructure section
* Skeleton blog post for GSoC small project wrap-up * GSoC 2024 - 2D visualization for small molecules (#28) * Create 2024-08-02-gsoc2024_talagayev.md * Update 2024-08-01-gsoc2024-final-sm.md * Changed Figure URL * Added figure for mdonatello display * Update 2024-08-02-gsoc2024_talagayev.md Adjusted the figure path * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Added RDKit ref Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md typo error an/a Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md typo error in shoutout Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Addition of google opensource link Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Adjusted code to widget Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update 2024-08-02-gsoc2024_talagayev.md removed separate import of mdonatello * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update 2024-08-02-gsoc2024_talagayev.md removed mention of stable version * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update 2024-08-02-gsoc2024_talagayev.md Separated into separate bullet points the features * Update 2024-08-02-gsoc2024_talagayev.md Adjusted the wording in the code restructure section --------- Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * GSoC 2024 - Streaming H5MD trajectories from cloud services (#29) * update lawson woods * acknowledgments tweaks * spelling * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * acknowledgements update --------- Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Add Lawson's md file name to blog post * Change blog post to current date * Change blog post titles to match Lawson and Valerij's actual posts --------- Co-authored-by: Valerij Talagayev <82884038+talagayev@users.noreply.github.com> Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> Co-authored-by: ljwoods2 <145226270+ljwoods2@users.noreply.github.com>
* Skeleton blog post for GSoC small project wrap-up * update lawson woods * acknowledgments tweaks * spelling * GSoC 2024 - 2D visualization for small molecules (#28) * Create 2024-08-02-gsoc2024_talagayev.md * Update 2024-08-01-gsoc2024-final-sm.md * Changed Figure URL * Added figure for mdonatello display * Update 2024-08-02-gsoc2024_talagayev.md Adjusted the figure path * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Added RDKit ref Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md typo error an/a Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md typo error in shoutout Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Addition of google opensource link Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Adjusted code to widget Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update 2024-08-02-gsoc2024_talagayev.md removed separate import of mdonatello * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update 2024-08-02-gsoc2024_talagayev.md removed mention of stable version * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update _posts/2024-08-02-gsoc2024_talagayev.md Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update 2024-08-02-gsoc2024_talagayev.md Separated into separate bullet points the features * Update 2024-08-02-gsoc2024_talagayev.md Adjusted the wording in the code restructure section --------- Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * Update _posts/2024-08-03-gsoc2024_woods.markdown Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> * acknowledgements update * start * WIP * add * fill out * spelling * add MHeyden paragraph * add registration * tweaks + schedule * grammarly * setup for interactive activity * Revert "Merge pull request #4 from ljwoods2/streaming" This reverts commit ffdade9, reversing changes made to db87686. * add Lawson changes manually * Apply suggestions from code review Co-authored-by: Oliver Beckstein <orbeckst@gmail.com> * add NSF logo * Update _posts/2024-11-3-ASU_streaming_workshop.md @HeydenLabASU correction (grammar) --------- Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Co-authored-by: Lawson Woods <ljwoods2@asu.edu> Co-authored-by: Valerij Talagayev <82884038+talagayev@users.noreply.github.com> Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> Co-authored-by: ljwoods2 <145226270+ljwoods2@users.noreply.github.com> Co-authored-by: Oliver Beckstein <orbeckst@gmail.com>
Here is my blog for the GSoC 2024 Wrap up:
2024-08-02-gsoc2024_talagayev.mdwith the blog2024-08-01-gsoc2024-final-sm.md@jennaswa I am not sure regarding the Figure, since I use a figure in my blog and from the previous GSoC 2023 final blogs the figures had a different format for the path that they were accessed, currently I have the url for the figure in the blog, should I somehow add the figure into the PR and change the path or how should it be?