Dasherize keys in relationship urls#106
Merged
jeregrine merged 1 commit intobeam-community:masterfrom May 2, 2018
Merged
Conversation
|
Thank you for this but I believe its a duplicate of an un-released pr #102 |
Contributor
Author
|
@jeregrine It's related, but it's not a duplicate. On master, after #102 was merged, if you run the test added here, the relationship's self url is when it should be |
|
Thanks! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for this library, it's really nice to use!
I noticed that the keys that become part of relationship urls weren't getting dashed. So this is a small test and fix. Should be compatible with #102.
Cheers!