Skip to content

Fix "this" is undefined for arrow functions #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix "this" is undefined for arrow functions #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,24 +124,28 @@ exports.generateEtag = data =>


// Check if valid S3 path
exports.isS3 = path => /^s3:\/\/.+\/.+/i.test(path)
const isS3 = path => /^s3:\/\/.+\/.+/i.test(path)

exports.isS3 = isS3


// Parse S3 path
exports.parseS3 = path => {
if (!this.isS3(path)) throw new FileError('Invalid S3 path',{path})
if (!isS3(path)) throw new FileError('Invalid S3 path',{path})
let s3object = path.replace(/^s3:\/\//i,'').split('/')
return { Bucket: s3object.shift(), Key: s3object.join('/') }
}


// Deep Merge
exports.deepMerge = (a,b) => {
const deepMerge = (a,b) => {
Object.keys(b).forEach(key => (key in a) ?
this.deepMerge(a[key],b[key]) : Object.assign(a,b) )
deepMerge(a[key],b[key]) : Object.assign(a,b) )
return a
}

exports.deepMerge = deepMerge

exports.mergeObjects = (obj1,obj2) =>
Object.keys(Object.assign({},obj1,obj2)).reduce((acc,key) => {
if (obj1[key] && obj2[key] && obj1[key].every(e => obj2[key].includes(e))) {
Expand Down