target: mbedos5: Add carriage return in jerry_port_console #1427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janjongboom
force-pushed
the
cr_after_lf
branch
from
cc3a159 to
d827e39
Compare
zherczeg
reviewed
Nov 14, 2016
| vfprintf (stdout, format, args); | ||
| va_end (args); | ||
|
|
||
| if (strlen(format) == 1 && format[0] == 0x0a) { /* line feed (\n) */ |
Member
There was a problem hiding this comment.
If this follows the JerryScript coding style please put the { to the next line.
Contributor
There was a problem hiding this comment.
And add whitespace after the strlen() like if (strlen (format)..., right @zherczeg ?
Member
|
Any plans to fix the style issues? |
janjongboom
force-pushed
the
cr_after_lf
branch
4 times, most recently
from
554a701 to
b9a04d7
Compare
Serial monitors (like screen on macOS / Linux) expect both CR and LF characters for new lines. Due to jerryscript only printing a line feed after calls to `print()` this makes log messages look wrong. This patch adds a CR when it encounters a LF character in jerry_port_console or jerry_port_log for the mbedos5 target. JerryScript-DCO-1.0-Signed-off-by: Jan Jongboom janjongboom@gmail.com
Contributor
Author
|
@zherczeg Done! |
Member
|
Thank you! |
LaszloLango
added
the
jerry-port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serial monitors (like screen on macOS / Linux) expect both CR and LF characters for new lines. Due to jerryscript only printing a line feed after calls to
print()this makes log messages look wrong. This patch adds a CR when it encounters a LF character in jerry_port_console or jerry_port_log for the mbedos5 target.JerryScript-DCO-1.0-Signed-off-by: Jan Jongboom jan.jongboom@arm.com
Fix for #1426